Display:
Hello all.

Comment tree view (the little arrows to collapse/expand the comment threads) no longer work for me, since a couple of days. Haven't changed anything to my profile or my firefox. My stupid organization may have made stupid changes to the proxy/firewalls though. But no site other than Eurotrib has changed in any way recently.

Anyone seen the same problem ?

Pierre

Pierre

by Pierre on Wed Jul 1st, 2009 at 10:55:28 AM EST
Now that you say it: I observed the same when I checked one of the 300+ comment threads a few days ago.

*Lunatic*, n.
One whose delusions are out of fashion.
by DoDo on Wed Jul 1st, 2009 at 11:05:10 AM EST
[ Parent ]
I get it on every page with the dynamic threading feature (which is active in user comment page, and in diaries with a few dozen messages in my settings).

The little arrows call a java script, which only refreshes the rating box for the clicked comment, and not the subthread.

Pierre

by Pierre on Wed Jul 1st, 2009 at 11:15:17 AM EST
[ Parent ]
Yes, I have noticed it at work...

A man of words and not of deeds is like a garden full of weeds; a man of deeds and not of words is like a garden full of turds — Anonymous
by Migeru (migeru at eurotrib dot com) on Wed Jul 1st, 2009 at 04:02:13 PM EST
[ Parent ]
I just checked, and it's not working for me either.
by afew (afew(a in a circle)eurotrib_dot_com) on Wed Jul 1st, 2009 at 04:27:56 PM EST
[ Parent ]
It works on Safari...

A man of words and not of deeds is like a garden full of weeds; a man of deeds and not of words is like a garden full of turds — Anonymous
by Migeru (migeru at eurotrib dot com) on Wed Jul 1st, 2009 at 05:04:38 PM EST
[ Parent ]
So to summarize:
  • broken for many people (presumably using Firefox or IE) since about a week
  • still works in Safari

Have we changed anything on the server lately ?

Pierre
by Pierre on Thu Jul 2nd, 2009 at 03:15:07 AM EST
[ Parent ]
Not to my knowledge...

*Lunatic*, n.
One whose delusions are out of fashion.
by DoDo on Thu Jul 2nd, 2009 at 07:23:51 AM EST
[ Parent ]
There was an issue of the images that makes the load link moving after the image update. I fixed that.

Now there is an error in the javascript.
There is this bit:
    // Get the set of comments out of the body
    if(body.children)
        divs = body.children.tags('DIV');
    else if(body.childNodes) {
        divs = new Array();
        for(var i = 0; i < body.childNodes.length; ++i)
            if(body.childNodes[i].tagName == 'DIV')
                divs.push(body.childNodes[i]);
    }

Where the if is trying to catch IE which implements children. Firefox didn't use to have that property at all and instead used childNodes. Now they do seem to have implemented a children property, but it does not have a method called tags, which apparently IE has. The cure is probably to swap the if and else if.

Do we have a proper way to access the dynamic-comments.js file? Else I can make a copy, upload it, and change the 'src' parameter in the appropriate <script> tag.

by someone (s0me1smail(a)gmail(d)com) on Thu Jul 2nd, 2009 at 07:34:14 AM EST
[ Parent ]
Probably easiest to make a new copy ...
by Colman (colman at eurotrib.com) on Thu Jul 2nd, 2009 at 07:45:24 AM EST
[ Parent ]
Do you mean the children property was implemented in firefox with a minor upgrade that got auto-downloaded ?

Pierre
by Pierre on Thu Jul 2nd, 2009 at 09:05:28 AM EST
[ Parent ]
I suppose this must be the case, since that bit of code has never caused problems before. Checking with the javascript shell <node>.children was indeed implemented in Firefox now.

I find this also:
element - MDC

children New in Firefox 3.5

So children seems to be a new property in Firefox 3.5. Working differently than the property with the same name in IE, though.
by someone (s0me1smail(a)gmail(d)com) on Thu Jul 2nd, 2009 at 09:35:41 AM EST
[ Parent ]
The comment tree works for me now, btw. So please check that this was the problem also for you.
by someone (s0me1smail(a)gmail(d)com) on Thu Jul 2nd, 2009 at 09:37:05 AM EST
[ Parent ]
yup, fixed it !
huurray !

Pierre
by Pierre on Thu Jul 2nd, 2009 at 09:57:50 AM EST
[ Parent ]
duh !
I'm still in 3.0.11 on the PC, gotta check on the Mac (which has the bug too), but I'm sure it's a 3.0.x

Pierre
by Pierre on Thu Jul 2nd, 2009 at 09:54:13 AM EST
[ Parent ]
Huh. Did they implement it earlier in secret?

Since I already zapped my earlier Firefox, could you try the shell at: http://www.squarefree.com/shell/shell.html and see if document.body.children is defined?

by someone (s0me1smail(a)gmail(d)com) on Thu Jul 2nd, 2009 at 10:19:03 AM EST
[ Parent ]
print(document.body.children)
undefined

this widget is really nice BTW

Pierre

by Pierre on Thu Jul 2nd, 2009 at 10:40:42 AM EST
[ Parent ]
but the mystery thickens, right ?

Pierre
by Pierre on Thu Jul 2nd, 2009 at 10:43:43 AM EST
[ Parent ]
Yup, that is strange. Because that was the code which got flagged by Firefox 3.5. And fixing it seems to have worked for you too. Bizarre!
by someone (s0me1smail(a)gmail(d)com) on Thu Jul 2nd, 2009 at 10:49:44 AM EST
[ Parent ]
Yup. It has some very nice features, including tab complete for implemented properties. Check out https://www.squarefree.com/bookmarklets/webdevel.html
to pick up the shell bookmark. When you invoke it you will get a new window that inherit the javascript environment from the current page. Very, very useful.
by someone (s0me1smail(a)gmail(d)com) on Thu Jul 2nd, 2009 at 10:52:08 AM EST
[ Parent ]

Display:
Login
. Make a new account
. Reset password
Recommended Diaries
Clipping the wings of a judge
by Migeru - Feb 10
25 comments

Hunger March wins PR battle
by DoDo - Feb 9
3 comments

Romania: protests change government
by DoDo - Feb 8
6 comments

Murdoch - Outsourcing and Hubris
by ceebs - Feb 3
18 comments

Obama wins GOP Primaries (to date)
by Frank Schnittger - Feb 8
8 comments

Sarkozy: Enemies Ahoy!
by afew - Feb 10
6 comments

LQD: Unsustainable irrigation
by Melanchthon - Feb 9

Bristol Pound
by ChrisCook - Feb 7
14 comments

Recent Diaries
Sarkozy: Enemies Ahoy!
by afew - Feb 10
6 comments

Clipping the wings of a judge
by Migeru - Feb 10
25 comments

LQD: Unsustainable irrigation
by Melanchthon - Feb 9

Hunger March wins PR battle
by DoDo - Feb 9
3 comments

Obama wins GOP Primaries (to date)
by Frank Schnittger - Feb 8
8 comments

Romania: protests change government
by DoDo - Feb 8
6 comments

Answers to the Renewable Energy Consultation
by Luis de Sousa - Feb 7

Bristol Pound
by ChrisCook - Feb 7
14 comments

The Imitation Of Germany
by afew - Feb 4
31 comments

Strange Fruit
by Frank Schnittger - Feb 4
14 comments

Murdoch - Outsourcing and Hubris
by ceebs - Feb 3
18 comments

Mismatch with the Natural Gas Market
by Luis de Sousa - Feb 3
22 comments

The Future of Economics
by ARGeezer - Feb 2
191 comments

Desert Island Discs - Helen's distortions
by Helen - Jan 31
48 comments

Gorila
by DoDo - Jan 29
14 comments

Rail News Blogging #7
by DoDo - Jan 29
15 comments

Obama's State Of The Union: LQD
by Crazy Horse - Jan 25
74 comments

Democracy Technology
by gmoke - Jan 24
1 comment

The Hydrogen dream
by Luis de Sousa - Jan 24
49 comments

ET Paris Meet-Up 2012 (2 UPDATE)
by afew - Jan 23
113 comments

More Diaries...
Occasional Series