Comment tree view (the little arrows to collapse/expand the comment threads) no longer work for me, since a couple of days. Haven't changed anything to my profile or my firefox. My stupid organization may have made stupid changes to the proxy/firewalls though. But no site other than Eurotrib has changed in any way recently.
Anyone seen the same problem ?
Pierre Pierre
The little arrows call a java script, which only refreshes the rating box for the clicked comment, and not the subthread. Pierre
Now there is an error in the javascript. There is this bit: // Get the set of comments out of the body if(body.children) divs = body.children.tags('DIV'); else if(body.childNodes) { divs = new Array(); for(var i = 0; i < body.childNodes.length; ++i) if(body.childNodes[i].tagName == 'DIV') divs.push(body.childNodes[i]); }
// Get the set of comments out of the body if(body.children) divs = body.children.tags('DIV'); else if(body.childNodes) { divs = new Array(); for(var i = 0; i < body.childNodes.length; ++i) if(body.childNodes[i].tagName == 'DIV') divs.push(body.childNodes[i]); }
Where the if is trying to catch IE which implements children. Firefox didn't use to have that property at all and instead used childNodes. Now they do seem to have implemented a children property, but it does not have a method called tags, which apparently IE has. The cure is probably to swap the if and else if.
if
children
childNodes
tags
else if
Do we have a proper way to access the dynamic-comments.js file? Else I can make a copy, upload it, and change the 'src' parameter in the appropriate <script> tag.
I find this also: element - MDC
children New in Firefox 3.5
Since I already zapped my earlier Firefox, could you try the shell at: http://www.squarefree.com/shell/shell.html and see if document.body.children is defined?
this widget is really nice BTW Pierre